Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[temp] feat: add import taxonomy button #8

Conversation

rpenido
Copy link
Member

@rpenido rpenido commented Nov 7, 2023

No description provided.

renovate bot and others added 8 commits November 6, 2023 13:26
…x#647)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#650)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…x#641)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…openedx#651)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v1.175.1 (openedx#663)

* fix(deps): update dependency @edx/frontend-lib-content-components to v1.175.1

* fix: upgrade paragon

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: KristinAoki <[email protected]>
Copy link
Member

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Could you have a look at ADR 002? According to that, we should add a new import-tags folder for this feature, with the components and functions in separate files underneath.

const getTaxonomyName = () => {
let taxonomyName = null;
while (!taxonomyName) {
taxonomyName = prompt('Enter a name for the new taxonomy');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings should be translatable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And using prompt and alert is temporary -- please add a comment at the top of this function to this effect so upstream know why we're doing it this way for now.

@rpenido rpenido force-pushed the rpenido/fal-3532-import-taxonomy branch 3 times, most recently from acf683e to da5e3f7 Compare November 8, 2023 20:42
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (chris/FAL-3528-taxonomy-export-menu@77a355e). Click here to learn what that means.

❗ Current head da5e3f7 differs from pull request most recent head 0c60c37. Consider uploading reports for the commit 0c60c37 to get more accurate results

Additional details and impacted files
@@                          Coverage Diff                           @@
##             chris/FAL-3528-taxonomy-export-menu       #8   +/-   ##
======================================================================
  Coverage                                       ?   87.52%           
======================================================================
  Files                                          ?      424           
  Lines                                          ?     6695           
  Branches                                       ?     1437           
======================================================================
  Hits                                           ?     5860           
  Misses                                         ?      804           
  Partials                                       ?       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks and works great @rpenido !

I'm not sure if we need tests added though? It might be difficult to test this temporary prompt/alert flow.

@rpenido rpenido force-pushed the rpenido/fal-3532-import-taxonomy branch from da5e3f7 to 0c60c37 Compare November 9, 2023 12:34
@rpenido
Copy link
Member Author

rpenido commented Nov 9, 2023

I'm not sure if we need tests added though? It might be difficult to test this temporary prompt/alert flow.

I agree. We expect this code to be temporary. I will check if the coverage report would allow us to let it pass.

Closed in favor of:

@rpenido rpenido closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants